Replace EndpointSlice reconciler with pod list backed by informer #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahg-g
force-pushed
the
informer
branch
6 times, most recently
from
876a472 to
63ca5c8
Compare
ahg-g
commented
Feb 3, 2025
| - dupword | ||
| - durationcheck | ||
| - fatcontext | ||
| - gci |
There was a problem hiding this comment.
We are not enforcing a specific import format, and so was causing issues.
ahg-g
commented
Feb 3, 2025
ahg-g
force-pushed
the
informer
branch
2 times, most recently
from
c5fc0bf to
30e6024
Compare
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
This supersedes #268 |
This was referenced Feb 3, 2025
liu-cong
reviewed
Feb 3, 2025
liu-cong
reviewed
Feb 4, 2025
liu-cong
reviewed
Feb 4, 2025
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold I would like to review this before we merge. |
|
I don't think this code can stay in this state. But it's more important that we get a release out and this seems to work for now. /lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
kfswain
added a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Feb 6, 2025
…rmer (kubernetes-sigs#271)" This reverts commit 9298849.
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
…bernetes-sigs#271) * Replace EndpointSlice reconciler with pod list backed by informer * Addressed comments
kfswain
added a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
…rmer (kubernetes-sigs#271)" (kubernetes-sigs#301) This reverts commit 9298849.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Fixes #158
The implementation is efficient in that it sets up an informer with a server-side selector on the pods that the pool selects. It also addresses a number of data staleness problems (e.g., selector being updated).
This can be expanded to support multi-tenant pools, but will be done as a followup if we decide to do it since we first need to define a way other than a flag to assign pools to epps (see #252)