logging cleanup of scheduler pkg #1806
Merged
+19
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is fixing few logging issues in the scheduling package.
for example (request-id and targetModelName are logged twice):
This is happening because the scheduler uses
WithValuesfor values that were already added to the logger.unsupported typeerror in the log:switched to using slice instead which should work as expected.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: