Skip to content

Conversation

@nirrozenbaum
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR does some cleanup to the quickstart guide.
two main changes:

  • Helm is mentioned as a pre-requisite at the beginning of the guide. therefore, the helm requirement was removed from KGateway section.
  • Istio DestinationRule is integrated into the helm chart (only when istio is selected as provider). therefore, it's no longer required to install it as part of the guide steps (or delete it). also, since DestinationRule is not used as a yaml anymore but part of the helm templates, the yaml file was deleted.
    Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: Nir Rozenbaum <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2025
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 55c308f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69088569f1cb2900083c2332
😎 Deploy Preview https://deploy-preview-1805--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

```

3. Deploy the HTTPRoute
2. Deploy the HTTPRoute
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC: Does netlify not allow us to always use 1 on Ordered Lists, standard markdown does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tried it once and it didn’t render as expected. I can try

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, we used automumbering with netlify in a previous project and it worked

@kfswain
Copy link
Collaborator

kfswain commented Nov 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit f3f6096 into kubernetes-sigs:main Nov 3, 2025
11 checks passed
@nirrozenbaum nirrozenbaum deleted the quickstart-cleanup branch November 3, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants