-
Notifications
You must be signed in to change notification settings - Fork 195
feat (reports): add infrastructure to run NGF conformance tests and i… #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (reports): add infrastructure to run NGF conformance tests and i… #1788
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
Welcome @sindhushiv! |
|
Hi @sindhushiv. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test @sindhushiv need to sign your commits to pass cla requirement. |
|
/lgtm This is so great to see nginx working with inference gateway! I’d be happy to see instructions for setting nginx also added to our quickstart guides in a follow up PR. Thanks! |
bjee19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving from ngf team
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bjee19, nirrozenbaum, sindhushiv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Optionally add one or more of the following kinds if applicable:
/area conformance-test
What this PR does / why we need it:
Adds a v1.0.2 gateway inference conformance report for the Nginx Gateway Fabric implementation.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?:
NONE