Skip to content

Conversation

@aman4433
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Fixes an incorrect example in the Observability documentation that used a string value for stream_options.include_usage instead of a boolean.
Which issue(s) this PR fixes:

Fixes #1751

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 22, 2025
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bd54bd0
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68f8d68714cab50008c3021a
😎 Deploy Preview https://deploy-preview-1758--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2025
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aman4433, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit c7f41ce into kubernetes-sigs:main Oct 22, 2025
10 checks passed
sallyom pushed a commit to sallyom/gateway-api-inference-extension that referenced this pull request Oct 28, 2025
BenjaminBraunDev pushed a commit to BenjaminBraunDev/gateway-api-inference-extension that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Observability Uses Incorrect stream_options Value

3 participants