-
Notifications
You must be signed in to change notification settings - Fork 190
Correct the InferencePoolResolvedRefsCondition conformance tests. #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@danehans are you planning to look at this PR? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:

The PR 0707d2f#diff-4fff24a24347da2990a6a84ae376c39de10be47f0b08f5f5ac480230dc723ee4 accidentally changed the verification a little bit and it can still pass the conformance test. But that's not what we want to test.
Run the test agianst GKE to make sure it still passes
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: