Skip to content

ext-proc: remove unused fields from EndpointSliceReconciler #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

ext-proc: remove unused fields from EndpointSliceReconciler #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/ext-proc/backend/endpointslice_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@ type EndpointSliceReconciler struct {
client.Client
Scheme *runtime.Scheme
Record record.EventRecorder
PoolName string
ServiceName string
Zone string
Namespace string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked...we actually don't use these fields anymore, since we now check if the ServiceName owns the EndpointSlice. I think we can remove the field altogether, thanks for catching this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfswain good point!
I've removed the field.

Datastore *K8sDatastore
}

Expand Down
1 change: 0 additions & 1 deletion pkg/ext-proc/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ func main() {
Record: mgr.GetEventRecorderFor("endpointslice"),
ServiceName: *serviceName,
Zone: *zone,
PoolName: *poolName,
}).SetupWithManager(mgr); err != nil {
klog.Error(err, "Error setting up EndpointSliceReconciler")
}
Expand Down