Skip to content

Helm fix #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

Helm fix #1540

merged 2 commits into from
Sep 5, 2025

Conversation

nirrozenbaum
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
This is a critical bug fix. currently it's not possible to use helm chart and get an inference pool without the app label because we use it in values.yaml.
this PR is fixing the issue. labels should be set through the helm install command.
Which issue(s) this PR fixes:

Fixes #1539

Does this PR introduce a user-facing change?:

NONE

@nirrozenbaum
bug fix in helm chart
d0a9b00 
Signed-off-by: Nir Rozenbaum <[email protected]>
@nirrozenbaum
comment
fed8ad4 
Signed-off-by: Nir Rozenbaum <[email protected]>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 5, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fed8ad4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68bb1b3ecd2cd2000815f987
😎 Deploy Preview https://deploy-preview-1540--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2025
@nirrozenbaum
Copy link
Contributor Author

cc: @kfswain @danehans

@nirrozenbaum
Copy link
Contributor Author

This is a critical bug for the release

@kfswain
Copy link
Collaborator

kfswain commented Sep 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
Gregory-Pereira
Gregory-Pereira approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Gregory-Pereira: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gregory-Pereira, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b9891d2 into kubernetes-sigs:main Sep 5, 2025
10 checks passed
nirrozenbaum added a commit that referenced this pull request Sep 5, 2025
@nirrozenbaum
Helm fix (#1540)
e868fb4 
* bug fix in helm chart

Signed-off-by: Nir Rozenbaum <[email protected]>

* comment

Signed-off-by: Nir Rozenbaum <[email protected]>

---------

Signed-off-by: Nir Rozenbaum <[email protected]>
@nirrozenbaum nirrozenbaum mentioned this pull request Sep 6, 2025
Open
@nirrozenbaum nirrozenbaum deleted the helm-fix branch September 7, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@elevran elevran Awaiting requested review from elevran

1 more reviewer

@Gregory-Pereira Gregory-Pereira Gregory-Pereira approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inferencepool chart sets a label that cannot be removed through helm
4 participants
@nirrozenbaum @kfswain @k8s-ci-robot @Gregory-Pereira