Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
current code includes a critical bug - plugins file is fixed to default-plugins.
This fix allows setting custom plugins configuration

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 31, 2025
Copy link

netlify bot commented Aug 31, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 6edef15
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68b469cc37fec400089cf194
😎 Deploy Preview https://deploy-preview-1508--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2025
@nirrozenbaum nirrozenbaum added this to the v1.0 (InferencePool GA) milestone Aug 31, 2025
@nirrozenbaum
Copy link
Contributor Author

This is critical for the release.
cc: @kfswain @ahg-g

@kfswain
Copy link
Collaborator

kfswain commented Aug 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2025
Signed-off-by: Nir Rozenbaum <[email protected]>
@kfswain
Copy link
Collaborator

kfswain commented Aug 31, 2025

/hold

For potential fixes

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 31, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 31, 2025

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 31, 2025
@nirrozenbaum
Copy link
Contributor Author

/retest

@nirrozenbaum
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2025
@nirrozenbaum
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2025
@nirrozenbaum nirrozenbaum reopened this Aug 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 93985b7 into kubernetes-sigs:main Aug 31, 2025
11 checks passed
@nirrozenbaum nirrozenbaum deleted the helm-plugins branch August 31, 2025 19:46
@kfswain
Copy link
Collaborator

kfswain commented Sep 2, 2025

Fixes: #1465

nirrozenbaum added a commit that referenced this pull request Sep 2, 2025
* allow setting custom plugins file through helm

Signed-off-by: Nir Rozenbaum <[email protected]>

* added `/`

Signed-off-by: Nir Rozenbaum <[email protected]>

---------

Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants