Skip to content

Fix the make build command and add main tag to the latest image #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix the make build command and add main tag to the latest image #127

merged 1 commit into from
Dec 20, 2024

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Dec 20, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 20, 2024
@ahg-g
Copy link
Contributor Author

ahg-g commented Dec 20, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@kfswain
Copy link
Collaborator

kfswain commented Dec 20, 2024

Since we are already modifying the makefile here, can we uncomment the verify now?

@ahg-g
Copy link
Contributor Author

ahg-g commented Dec 20, 2024

Since we are already modifying the makefile here, can we uncomment the verify now?

not yet, not all lints are solved

@ahg-g
Copy link
Contributor Author

ahg-g commented Dec 20, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@kfswain
Copy link
Collaborator

kfswain commented Dec 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit d2bdb8e into kubernetes-sigs:main Dec 20, 2024
4 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
@ahg-g @kfswain
Fix the make build command and add main tag to the latest image (kube…
0847881 
…rnetes-sigs#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

@robscott robscott Awaiting requested review from robscott

Assignees

@kfswain kfswain

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahg-g @k8s-ci-robot @kfswain