removed cmd/registry file #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nir Rozenbaum <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Nir Rozenbaum <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Jul 31, 2025
* removed cmd/registry file Signed-off-by: Nir Rozenbaum <[email protected]> * register Signed-off-by: Nir Rozenbaum <[email protected]> --------- Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does minor structuring changes to config api -
cmd/registry.gofile which contained the "RegisterAllPlugins" function and the handle concrete implementation.registerInTreePlugins. this change bakes the GIE plugins inside the runner without the necessity to register them when a different project would like to reuse GIE. for example in llm-d, the line to register GIE plugins would no longer be needed - https://github.com/llm-d/llm-d-inference-scheduler/blob/main/cmd/epp/main.go#L41 (we treat GIE plugins as a base set of plugins that are always shipped with GIE).plugins/handle.gofile which seems like the natural place for this implementation.