added graceful shutdown when scheduler config is not initialized #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nir Rozenbaum <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm We should provide a default config when one not set. |
k8s-ci-robot
added
the
lgtm
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Jul 31, 2025
…ernetes-sigs#1198) Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes segmentation fault that may happen if the scheduler config is not initialized.
in GIE we allow configuring plugins either through config api or through code.
therefore when the config flags are missing, the program doesn't exit (to allow configuration by code to work).
we should add a nil check to validate we don't get segmentation fault when trying to initialize the scheduler.
this issue was originally hit in llm-d-scheduler, and reported here:
llm-d/llm-d-inference-scheduler#255