Skip to content

Add support for plugin configuration in the InferencePool helm chart #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Add support for plugin configuration in the InferencePool helm chart #1168

merged 2 commits into from
Jul 16, 2025

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Jul 15, 2025

Fixes #1137

/assign @nirrozenbaum

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested review from danehans and kfswain July 15, 2025 23:58
@netlify Netlify
Copy link

netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 04dceb3
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6877bacc584c360008e1e26c
😎 Deploy Preview https://deploy-preview-1168--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2025
nirrozenbaum
nirrozenbaum reviewed Jul 16, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Jul 16, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Jul 16, 2025
View reviewed changes
nirrozenbaum
nirrozenbaum reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
I left just a few nits.

I assume it was tested with some custom config?

@ahg-g
Copy link
Contributor Author

ahg-g commented Jul 16, 2025 •
edited
Loading

This looks great. I left just a few nits.

I assume it was tested with some custom config?

yes, although we need to improve logging, we should log the configuration, I pushed another commit for that.

@nirrozenbaum
Copy link
Contributor

this is great!
just one issue from ci checks to handle

@nirrozenbaum
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit a6f468c into kubernetes-sigs:main Jul 16, 2025
9 checks passed
nirrozenbaum pushed a commit that referenced this pull request Jul 16, 2025
@ahg-g @nirrozenbaum
Add support for plugin configuration in the InferencePool helm chart (#…
f18cf4c 
…1168)

* Add support for plugin configuration in the InferencePool helm chart

* rename flags
@ahg-g ahg-g mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@danehans danehans Awaiting requested review from danehans

@kfswain kfswain Awaiting requested review from kfswain

Assignees

@nirrozenbaum nirrozenbaum

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an epp config flag to the InferencePool helm chart
3 participants
@ahg-g @k8s-ci-robot @nirrozenbaum