Skip to content

Conversation

danehans
Copy link
Contributor

Fixes the EPP configmap namespace in the conformance manifest.

Fixes #1164

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2025
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 8d1b5d5
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68768e75d81c2200089146e4
😎 Deploy Preview https://deploy-preview-1166--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g July 15, 2025 17:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from liu-cong July 15, 2025 17:12
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
@danehans danehans changed the title Conformance: Fixes the EPP ConfigMap namespace Conformance: Fixes the EPP ConfigMap Namespace Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2025
@danehans danehans requested a review from nirrozenbaum July 15, 2025 17:12
@danehans
Copy link
Contributor Author

I confirmed that conformance tests are no longer blocked with this PR:

--- PASS: TestConformance (42.25s)
    --- SKIP: TestConformance/EppUnAvailableFailOpen (0.00s)
    --- PASS: TestConformance/GatewayFollowingEPPRouting (7.33s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_a_single_designated_pod (0.31s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_two_designated_pods (0.29s)
        --- PASS: TestConformance/GatewayFollowingEPPRouting/should_route_traffic_to_all_available_pods (0.31s)
    --- PASS: TestConformance/HTTPRouteInvalidInferencePoolRef (1.03s)
        --- PASS: TestConformance/HTTPRouteInvalidInferencePoolRef/HTTPRoute_should_have_Accepted=True_and_ResolvedRefs=False_for_non-existent_InferencePool (1.01s)
    --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (1.37s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Primary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (1.11s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Secondary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (0.22s)
    --- PASS: TestConformance/InferencePoolAccepted (0.04s)
        --- PASS: TestConformance/InferencePoolAccepted/InferencePool_should_have_Accepted_condition_set_to_True (0.01s)
    --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation (1.26s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_1:_HTTPRoute_backendRef_to_InferencePool_with_Port_Unspecified (1.11s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_2:_HTTPRoute_backendRef_to_InferencePool_with_Port_Specified_and_Matching (0.05s)
        --- PASS: TestConformance/InferencePoolHTTPRoutePortValidation/Scenario_3:_HTTPRoute_backendRef_to_InferencePool_with_Port_Specified_and_Non-Matching._Request_still_passing_because_HTTP_Port_is_ignored_when_inferencePool_is_backendRef (0.04s)
    --- PASS: TestConformance/InferencePoolInvalidEPPService (1.07s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/InferecePool_has_a_ResolvedRefs_Condition_with_status_False (0.00s)
        --- PASS: TestConformance/InferencePoolInvalidEPPService/Request_to_a_route_with_an_invalid_backend_reference_receives_a_500_response (0.01s)
    --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools (1.24s)
        --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Wait_for_resources_to_be_accepted (1.02s)
        --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path (0.20s)
            --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path/request_to_primary_pool (0.10s)
            --- PASS: TestConformance/HTTPRouteMultipleRulesDifferentPools/Traffic_should_be_routed_to_the_correct_pool_based_on_path/request_to_secondary_pool (0.10s)
    --- PASS: TestConformance/InferencePoolResolvedRefsCondition (11.35s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/InferencePool_should_show_Accepted:True_by_parents_and_be_routable_via_multiple_HTTPRoutes (0.20s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-primary-gw_and_verify_InferencePool_status_and_routing_via_secondary_gw (5.06s)
        --- PASS: TestConformance/InferencePoolResolvedRefsCondition/Delete_httproute-for-secondary-gw_and_verify_InferencePool_has_no_parent_statuses_and_is_not_routable (5.02s)
PASS
ok  	sigs.k8s.io/gateway-api-inference-extension/conformance	42.285s

@danehans danehans requested a review from nirrozenbaum July 15, 2025 17:23
@nirrozenbaum
Copy link
Contributor

/lgtm

Thanks! 🙏🏼

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9a5491f into kubernetes-sigs:main Jul 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance: EPP Panics
3 participants