Skip to content

feat: move x-k8s to apix and add v1 InferencePool to api/v1 #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jul 21, 2025
Merged

feat: move x-k8s to apix and add v1 InferencePool to api/v1 #1116

merged 36 commits into from
Jul 21, 2025

Conversation

capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Jul 7, 2025 •
edited
Loading

  1. move inference.networking.x-k8s.io resources from /api to /apix
  2. add inference.networking.k8s.io resources in /api

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 0189c33
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/687a7e324537890008bac555
😎 Deploy Preview https://deploy-preview-1116--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 7, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @robscott

@capri-xiyue capri-xiyue changed the title feat: move x-k8s to apix and add v1 InferencePool to api/v1 [WIP] feat: move x-k8s to apix and add v1 InferencePool to api/v1 Jul 7, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@capri-xiyue
Copy link
Contributor Author

It's ready for review. I added DO-NOT-MERGE because this PR should be merged in v1 branch

@capri-xiyue capri-xiyue changed the base branch from main to release-1.0 July 7, 2025 21:06
@capri-xiyue capri-xiyue changed the title [WIP] feat: move x-k8s to apix and add v1 InferencePool to api/v1 feat: move x-k8s to apix and add v1 InferencePool to api/v1 Jul 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@capri-xiyue
Copy link
Contributor Author

It's ready for review. I added DO-NOT-MERGE because this PR should be merged in v1 branch

Change the base to be kubernetes-sigs:release-1.0

@kfswain
Copy link
Collaborator

kfswain commented Jul 7, 2025 •
edited
Loading

/hold

Adding this label until we have confirmation that we can merge this PR without sig-net approval (or getting sig-net approval)

@kfswain kfswain added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@capri-xiyue capri-xiyue mentioned this pull request Jul 7, 2025
Merged
@kfswain
Copy link
Collaborator

kfswain commented Jul 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2025
@capri-xiyue
Copy link
Contributor Author

/retest

@capri-xiyue
Copy link
Contributor Author

/retest

@capri-xiyue
Copy link
Contributor Author

/retest

@capri-xiyue
Copy link
Contributor Author

/retest

robscott
robscott approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @capri-xiyue!

/hold until v0.5 has been released.

@capri-xiyue capri-xiyue mentioned this pull request Jul 16, 2025
Closed
@kfswain
Copy link
Collaborator

kfswain commented Jul 16, 2025

This LGTM. It looks like all code within the EPP hasnt changed reference to the alpha version, so this PR is mostly just noise related to the code gen and new directories generated.

RC 2 of v0.5 is cut, so this can potentially be merged, as we could just cherry pick fixes into the release branch. I'll approve and leave the decision to @robscott & @capri-xiyue.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, kfswain, robscott, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Jul 16, 2025 •
edited
Loading

This LGTM. It looks like all code within the EPP hasnt changed reference to the alpha version, so this PR is mostly just noise related to the code gen and new directories generated.

RC 2 of v0.5 is cut, so this can potentially be merged, as we could just cherry pick fixes into the release branch. I'll approve and leave the decision to @robscott & @capri-xiyue.

/approve

The epp change is included in #1118, capri-xiyue#1 is a mirror. Once you finish the review of #1118 (capri-xiyue#1 ) we can merge them together.

@zetxqx
Copy link
Contributor

zetxqx commented Jul 17, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

@zetxqx: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@capri-xiyue capri-xiyue mentioned this pull request Jul 17, 2025
Closed
@capri-xiyue
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jul 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1ea9959 into kubernetes-sigs:main Jul 21, 2025
9 checks passed
This was referenced Jul 22, 2025
Closed
Closed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
@capri-xiyue @robscott @kfswain
feat: move x-k8s to apix and add v1 InferencePool to api/v1 (kubernet…
cdfcdd8 
…es-sigs#1116)

* rename x-k8s to apix and add v1 InferencePool to api/v1

* updated docker file

* fixed naming collision

* added fake approved annotation

* try to fix unit tests

* fixed typo

* added annotation

* fixed annotation

* Update api/v1/inferencepool_types.go

Co-authored-by: Rob Scott <[email protected]>

* Apply suggestions from code review

Co-authored-by: Rob Scott <[email protected]>

* use v1 type in v1alpha2

* clean unused depdendency

* fixed code generator error

* revert back

* merge bob's change

* upadted code-gen

* remove deep copy needs

* use codegen

* revert to workable version

* re-run generate

* revert to workable version

* change to use v1alpha2 back

* resolve merge conflicts

* fixed typo

* fixed typo

* fixed pipeline

* fixed boilerplate

Signed-off-by: Xiyue Yu <[email protected]>

* updated missing dependency

* fixed change

* fixed format

* fixed import issue

* fixed format

---------

Signed-off-by: Xiyue Yu <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfswain kfswain Awaiting requested review from kfswain

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

2 more reviewers

@zetxqx zetxqx zetxqx approved these changes

@robscott robscott robscott approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@robscott robscott

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@capri-xiyue @k8s-ci-robot @kfswain @zetxqx @robscott