Only create LOCALBIN directory when it does not exist #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @elevran. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, elevran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shmuelk
pushed a commit
to shmuelk/gateway-api-inference-extension
that referenced
this pull request
Jun 25, 2025
…s#1054) The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Jun 26, 2025
…s#1054) The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Jun 26, 2025
…s#1054) The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
EyalPazz
pushed a commit
to EyalPazz/gateway-api-inference-extension
that referenced
this pull request
Jul 9, 2025
…s#1054) The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
11 tasks
BenjaminBraunDev
pushed a commit
to BenjaminBraunDev/gateway-api-inference-extension
that referenced
this pull request
Aug 12, 2025
…s#1054) The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Makefile rule was calling mkdir -p without checking existence first.
This would change the directory's mtime and cause all files underneath to become "older".
Since all tools underneath also declare LOCALBIN directory as a dependency, they would be
downloaded/rebuilt more frequently than needed.