InferencePool Status Condition Defaulting

[danehans]

Currently, InferencePool status is defined as:

type PoolStatus struct {
...
	// Conditions track the state of the InferencePool.
	//
	// Known condition types are:
	//
	// * "Accepted"
	// * "ResolvedRefs"
	//
	// +optional
	// +listType=map
	// +listMapKey=type
	// +kubebuilder:validation:MaxItems=8
	// +kubebuilder:default={{type: "Accepted", status: "Unknown", reason:"Pending", message:"Waiting for controller", lastTransitionTime: "1970-01-01T00:00:00Z"}}
	Conditions []metav1.Condition `json:"conditions,omitempty"`

The Status=Unknown condition is not being defaulted, even though the +kubebuilder:default tag is defined. This is because PoolStatus is a field of InferencePoolStatus, e.g. Parents []PoolStatus, and is not being defaulted.

Here are a few options to resolve this issue:

1. Remove the defaulting behavior.
2. Since OpenAPI does not support specifying default values for array items, restructure InferencePool status conditions so they are not per Gateway.

[danehans]

cc: @robscott

[robscott]

Good catch @danehans!

I think we need to copy what GW API does here with a higher level default: https://github.com/kubernetes-sigs/gateway-api/blob/344f8de09c63f03077743df802888d22e78712fe/apis/v1/gateway_types.go#L44