generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 180
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Description
Some values are being repeated throughout the codebase. Take the EPP gRPC listening port for example:
$ grep -ri 9002 pkg/
pkg/ext-proc/test/benchmark/benchmark.go: svrAddr = flag.String("server_address", "localhost:9002", "Address of the ext proc server")
pkg/ext-proc/test/benchmark/benchmark.go: port = 9002
pkg/ext-proc/test/hermetic_test.go: port = 9002
pkg/ext-proc/main.go: 9002,
We should audit CLI flag usage and create public constants for values that are used repeatedly in the codebase.
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.