Skip to content

🌱Bump golangci-lint to v1.63.4 #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

🌱Bump golangci-lint to v1.63.4 #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # tag=v6.2.0
with:
version: v1.61.0
version: v1.63.4
args: --out-format=colored-line-number
working-directory: ${{matrix.working-directory}}
13 changes: 13 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@ run:
# while if uncached!
timeout: 10m

linters:
enable:
Copy link
Member

@sbueringer sbueringer Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a short list. How did we decide which ones to enable?

Wondering if we should try to enable the same as in CR (potentially split up in multiple PRs if there would be a lot of findings)

Copy link
Contributor Author

@dongjiang1989 dongjiang1989 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbueringer

In my opinion it should be possible to enable all linters.

Under the previous default settings, .golangci.yaml only enabled [errcheck gosimple govet ineffassign staticcheck unused] linter.
image

I'll add other linters for next PR.

Copy link
Member

@sbueringer sbueringer Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thx!

In my opinion it should be possible to enable all linters.

Just to avoid misunderstandings. I would only enable the ones enabled in controller-runtime (vs. all :))

Copy link
Contributor Author

@dongjiang1989 dongjiang1989 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid misunderstandings. I would only enable the ones enabled in controller-runtime (vs. all :))

Thanks!
I got it.

- errcheck
- gosimple
- govet
- ineffassign
- staticcheck
- unused
- testifylint
- iface
- exptostd
- nilnesserr

issues:
exclude-rules:
# Dot imports for gomega and ginkgo are allowed
Expand Down
Loading