Skip to content

[release-0.22] 🐛Follow up for namespace client test #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
+11 −1
Merged

[release-0.22] 🐛Follow up for namespace client test #3357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/client/namespaced_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import (

var _ = Describe("NamespacedClient", func() {
var dep *appsv1.Deployment
var nameSpace *corev1.Namespace
var acDep *appsv1applyconfigurations.DeploymentApplyConfiguration
var ns = "default"
var count uint64 = 0
Expand Down Expand Up @@ -82,6 +83,12 @@ var _ = Describe("NamespacedClient", func() {
},
},
}
nameSpace = &corev1.Namespace{
ObjectMeta: metav1.ObjectMeta{
Name: fmt.Sprintf("namespace-%v", count),
Labels: map[string]string{"name": fmt.Sprintf("namespace-%v", count)},
},
}
acDep = appsv1applyconfigurations.Deployment(dep.Name, "").
WithLabels(dep.Labels).
WithSpec(appsv1applyconfigurations.DeploymentSpec().
Expand Down Expand Up @@ -133,10 +140,13 @@ var _ = Describe("NamespacedClient", func() {
var err error
dep, err = clientset.AppsV1().Deployments(ns).Create(ctx, dep, metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
nameSpace, err = clientset.CoreV1().Namespaces().Create(ctx, nameSpace, metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
})

AfterEach(func(ctx SpecContext) {
deleteDeployment(ctx, dep, ns)
deleteNamespace(ctx, nameSpace)
})

It("should successfully List objects when namespace is not specified with the object", func(ctx SpecContext) {
Expand All @@ -149,7 +159,7 @@ var _ = Describe("NamespacedClient", func() {
})

It("should successfully List objects when object is not namespaced scoped", func(ctx SpecContext) {
result := &corev1.NodeList{}
result := &corev1.NamespaceList{}
opts := &client.ListOptions{}
Expect(getClient().List(ctx, result, opts)).NotTo(HaveOccurred())
Expect(result.Items).NotTo(BeEmpty())
Expand Down