🌱 Further cleanup internal/informers #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
vincepri
force-pushed
the
cleanup-internal-informers
branch
2 times, most recently
from
0503ad8 to
b54e705
Compare
Member
Author
|
/assign @sbueringer |
sbueringer
reviewed
Jan 17, 2023
Member
sbueringer
left a comment
sbueringer
left a comment
There was a problem hiding this comment.
A few nits, otherwise lgtm
vincepri
force-pushed
the
cleanup-internal-informers
branch
from
b54e705 to
a78570d
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
cleanup-internal-informers
branch
from
a78570d to
0f07001
Compare
k8s-ci-robot
removed
the
lgtm
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]