Skip to content

Mark leak goroutine tests as pending #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Mark leak goroutine tests as pending #1070

merged 1 commit into from
Jul 23, 2020
+6 −2

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

This PR disables the leak goroutine tests that are causing a lot of flakes in CI. After a conversation on Slack with @alvaroaleman, we agreed that these tests are very error-prone and should be revisited/rewritten later on.

/milestone v0.6.x

@k8s-ci-robot k8s-ci-robot added this to the v0.6.x milestone Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2020
@vincepri vincepri mentioned this pull request Jul 23, 2020
Closed
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

alvaroaleman
alvaroaleman approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master

@alvaroaleman
Copy link
Member

alvaroaleman commented Jul 23, 2020 •
edited
Loading

Created #1071 for the data race, not sure why it only appears sometimes

@vincepri
Copy link
Member Author

/test pull-controller-runtime-test-master
/honk

@k8s-ci-robot
Copy link
Contributor

@vincepri:
goose image

In response to this:

/test pull-controller-runtime-test-master
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 49e1044 into kubernetes-sigs:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@vincepri @k8s-ci-robot @alvaroaleman