Skip to content

Commit 49e1044

Browse files
authored
Merge pull request #1070 from vincepri/disable-leak-tests
Mark leak goroutine tests as pending
2 parents e9ea67c + 51487c9 commit 49e1044

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

pkg/controller/controller_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@ var _ = Describe("controller.Controller", func() {
9393
close(done)
9494
})
9595

96-
It("should not leak goroutines when stop", func(done Done) {
96+
// This test has been marked as pending because it has been causing lots of flakes in CI.
97+
// It should be rewritten at some point later in the future.
98+
XIt("should not leak goroutines when stop", func(done Done) {
9799
// TODO(directxman12): After closing the proper leaks on watch this must be reduced to 0
98100
// The leaks currently come from the event-related code (as in corev1.Event).
99101
threshold := 3

pkg/manager/manager_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1168,7 +1168,9 @@ var _ = Describe("manger.Manager", func() {
11681168
})
11691169
})
11701170

1171-
It("should not leak goroutines when stop", func(done Done) {
1171+
// This test has been marked as pending because it has been causing lots of flakes in CI.
1172+
// It should be rewritten at some point later in the future.
1173+
XIt("should not leak goroutines when stop", func(done Done) {
11721174
// TODO(directxman12): After closing the proper leaks on watch this must be reduced to 0
11731175
// The leaks currently come from the event-related code (as in corev1.Event).
11741176
threshold := 3

0 commit comments

Comments
 (0)