🌱 Follow-up on the removal of clusterctl watching namespace #4695
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
|
||
| // checkTargetProviders checks that all the providers installed in the source cluster exists in the target cluster as well (with a version >= of the current version). | ||
| func (o *objectMover) checkTargetProviders(namespace string, toInventory InventoryClient) error { | ||
| func (o *objectMover) checkTargetProviders(toInventory InventoryClient) error { |
There was a problem hiding this comment.
Removing watching namespace logic from this method is a leftover from #4666
|
|
||
| // Migrate the additional provider attributes to the upgrade item | ||
| // such as watching namespace. | ||
| upgradeItem.WatchedNamespace = provider.WatchedNamespace |
There was a problem hiding this comment.
This is a leftover from #4666
|
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retitle 🌱 Follow-up on the removal of clustectl watching namespace |
k8s-ci-robot
changed the title
vincepri
changed the title
3 participants
What this PR does / why we need it:
This PR is a follow up of #4666; it removes watching namespace from fakeObjects & tests.
It includes also two leftover cleanups from the above PR