Skip to content

🌱Adapt clusterctl move to requirements for the new multi-tenancy model #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

🌱Adapt clusterctl move to requirements for the new multi-tenancy model #4628

merged 1 commit into from
Jun 3, 2021

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented May 17, 2021 •
edited
Loading

What this PR does / why we need it:
This PR makes clusterctl move ready to handle the new multi-tenancy model.

More specifically, now clusterctl can:

  • handle infrastructure cluster global identity and their underlying hierarchy of objects, e.g. the secret with credentials in the infrastructure provider namespaces

Providers are required to apply the clusterctl.cluster.x-k8s.io/move-hierarchy label on the infrastructure cluster global identity CRDs.

Which issue(s) this PR fixes:
Fixes: #3042

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2021
@fabriziopandini fabriziopandini marked this pull request as draft May 17, 2021 20:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021
@fabriziopandini fabriziopandini mentioned this pull request May 17, 2021
Closed
@sedefsavas sedefsavas mentioned this pull request May 19, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2021
@fabriziopandini fabriziopandini force-pushed the clusterctl-move-multi-tenancy branch from f807185 to 88b3ee3 Compare May 31, 2021 17:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2021
@fabriziopandini fabriziopandini marked this pull request as ready for review May 31, 2021 17:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2021
@fabriziopandini
Copy link
Member Author

@vincepri @randomvariable @yastij
This is now ready for review, PTAL

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@yastij
Copy link
Member

yastij commented Jun 1, 2021

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yastij June 1, 2021 12:27
vincepri
vincepri approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit ded3b90 into kubernetes-sigs:master Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 3, 2021
@fabriziopandini fabriziopandini deleted the clusterctl-move-multi-tenancy branch June 4, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincepri vincepri vincepri approved these changes

@moshloop moshloop Awaiting requested review from moshloop

@sbueringer sbueringer Awaiting requested review from sbueringer

@yastij yastij Awaiting requested review from yastij

Assignees

@vincepri vincepri

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v0.4

Development

Successfully merging this pull request may close these issues.

Adapt clusterctl move to the new multi-tenancy model

4 participants

@fabriziopandini @yastij @k8s-ci-robot @vincepri