Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/crd/bases/exp.cluster.x-k8s.io_machinepools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ spec:
to.
minLength: 1
type: string
failureDomains:
description: FailureDomains is the list of failure domains this MachinePool
should be attached to.
items:
type: string
type: array
minReadySeconds:
description: Minimum number of seconds for which a newly created machine
instances should be ready. Defaults to 0 (machine instance will
Expand Down
4 changes: 3 additions & 1 deletion docs/proposals/20190919-machinepool-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ type MachinePoolSpec struct
- **ClusterName [required]**
- Type: `string`
- Description: Name of the Cluster this machine pool belongs to.
- **FailureDomains [optional]**
- Type: `[]string`
- Description: FailureDomains is the list of failure domains this MachinePool should be attached to.
- **Replicas [optional]**
- Type: `*int32`
- Description: Number of desired machine instances. Defaults to 1.
Expand Down Expand Up @@ -415,4 +418,3 @@ inconsistent experience across providers.
10/23/2019: First round of feedback from community
10/23/2019: Present proposal at a community meeting
10/31/2019: Open proposal PR

3 changes: 3 additions & 0 deletions exp/api/v1alpha3/machinepool_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ type MachinePoolSpec struct {
// This field must match the provider IDs as seen on the node objects corresponding to a machine pool's machine instances.
// +optional
ProviderIDList []string `json:"providerIDList,omitempty"`

// FailureDomains is the list of failure domains this MachinePool should be attached to.
FailureDomains []string `json:"failureDomains,omitempty"`
}

// ANCHOR_END: MachinePoolSpec
Expand Down
5 changes: 5 additions & 0 deletions exp/api/v1alpha3/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.