Skip to content

📖 Renaming ErrorMessage and ErrorReason to FailureMessage and FailureReason in docs #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2019
Merged

📖 Renaming ErrorMessage and ErrorReason to FailureMessage and FailureReason in docs #1822

merged 1 commit into from
Dec 5, 2019

Conversation

@noamran
Copy link
Contributor

@noamran noamran commented Dec 3, 2019

What this PR does / why we need it:
Changing ErrorMessage and ErrorReason to FailureMessage and FailureReason in docs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

Hi @noamran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2019
@detiber
Copy link
Contributor

detiber commented Dec 3, 2019

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, noamran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
noamran
noamran commented Dec 3, 2019
View reviewed changes
docs/book/src/architecture/controllers/machine.md

* `errorReason` - is a string that explains why an error has occurred, if possible.
* `errorMessage` - is a string that holds the message contained by the error.
* `failureReason` - is a string that explains why a fatal error has occurred, if possible.
Copy link
Contributor Author

@noamran noamran Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is only relevant after #1800 is merged.

docs/book/src/architecture/controllers/machine.md
```yaml
kind: MyBootstrapProviderConfig
apiVersion: bootstrap.cluster.x-k8s.io/v1alpha2
apiVersion: bootstrap.cluster.x-k8s.io/v1alpha3
Copy link
Contributor Author

@noamran noamran Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is only relevant after #1800 is merged.

@ncdc
Copy link
Contributor

ncdc commented Dec 3, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@detiber
Copy link
Contributor

detiber commented Dec 3, 2019

/hold
waiting on #1800 as a prerequisite

@detiber
Copy link
Contributor

detiber commented Dec 3, 2019

/test pull-cluster-api-integration

@noamran
Copy link
Contributor Author

noamran commented Dec 5, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7eb721b into kubernetes-sigs:master Dec 5, 2019
@noamran noamran deleted the docs-error branch January 9, 2020 18:09
@noamran noamran mentioned this pull request Jan 22, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chuckha chuckha Awaiting requested review from chuckha

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@detiber detiber

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noamran @k8s-ci-robot @detiber @ncdc