Skip to content

Conversation

@detiber
Copy link
Contributor

@detiber detiber commented Oct 11, 2019

What this PR does / why we need it:

  • Update controller-runtime to v0.3.0
  • Update golang used to v1.12.10

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@detiber detiber force-pushed the updateControllerRuntime branch from 9d6cbf7 to d707649 Compare October 11, 2019 12:19
- Update controller-runtime to v0.3.0
- Update golang used to v1.12.10
@detiber detiber force-pushed the updateControllerRuntime branch from cdb6549 to ba392bb Compare October 11, 2019 12:28
@vincepri vincepri changed the title 🐛 Update controller-runtime and golang versions 🏃 Update controller-runtime and golang versions Oct 11, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2fa1614 into kubernetes-sigs:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants