🏃Add unit tests for machine controller #1493
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @wfernandes. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test I'll take a look this afternoon |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
|
||
| key := client.ObjectKey{Namespace: tc.m.Namespace, Name: tc.m.Name} | ||
| if len(tc.expectedFinalizers) > 0 { | ||
| Expect(mr.Client.Get(ctx, key, tc.m)).ToNot(HaveOccurred()) |
There was a problem hiding this comment.
Instead of storing into tc.m, let's create a var m clusterv1.Machine and store into &m, then compare m.Finalizers with tc.expectedFinalizers.
There was a problem hiding this comment.
@ncdc The other reason I kept m in the struct was for key := client.ObjectKey{Namespace: tc.m.Namespace, Name: tc.m.Name}
I can pass in the namespace and name explicitly into the struct but I thought this was readable.
| clusterv1.AddToScheme(scheme.Scheme) | ||
| mr := &MachineReconciler{ | ||
| Client: fake.NewFakeClientWithScheme( | ||
| scheme.Scheme, |
There was a problem hiding this comment.
This can probably be omitted and use the other New method without the scheme, given that the scheme is initialized in suite_test.go
There was a problem hiding this comment.
The reason I used this method was because fake.NewFakeClient is marked as deprecated.
There was a problem hiding this comment.
@vincepri Also if you are referring to the scheme being initialized in the suite_test.go in the BeforeSuite, I assumed that this would be run as part of the ginkgo/integration tests and not for the unit tests when running go test -run=TestMachineFinalizer
|
|
||
| func TestRemoveMachineFinalizerAfterDeleteReconcile(t *testing.T) { | ||
| RegisterTestingT(t) | ||
| clusterv1.AddToScheme(scheme.Scheme) |
Signed-off-by: Warren Fernandes <[email protected]>
wfernandes
force-pushed
the
add-machine-controller-tests
branch
from
eaa3d91 to
73af52b
Compare
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, wfernandes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
5 participants
Signed-off-by: Warren Fernandes [email protected]
What this PR does / why we need it:
This PR adds some additional unit tests for
machine_controller.go. It also refactors other pre-existing tests to make them a little more readable.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):NA