⚠️ Clarify Machine.Spec.ObjectMeta use in godoc #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ncdc
reviewed
Sep 26, 2019
Contributor
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
vincepri
force-pushed
the
fix-objectmeta-comment
branch
from
80c73c2 to
ead62ec
Compare
k8s-ci-robot
removed
the
lgtm
Member
Author
|
/hold cancel ptal |
k8s-ci-robot
removed
the
do-not-merge/hold
ncdc
reviewed
Sep 26, 2019
vincepri
force-pushed
the
fix-objectmeta-comment
branch
2 times, most recently
from
90d3465 to
bd62092
Compare
k8s-ci-robot
added
size/M
ncdc
reviewed
Sep 26, 2019
api/v1alpha2/machine_types.go
Outdated
| // MachineSpec defines the desired state of Machine | ||
| type MachineSpec struct { | ||
| // ObjectMeta will autopopulate the Node created. Use this to | ||
| // DEPRECATED: ObjectMeta will autopopulate the Node created. Use this to |
Contributor
There was a problem hiding this comment.
Let's not leave the text in here about autopopulating stuff. It's incorrect.
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
fix-objectmeta-comment
branch
from
bd62092 to
872349b
Compare
k8s-ci-robot
added
size/S
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Not a breaking change, but wanted to make it clear for users that this didn't do what it said it did.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #