Skip to content

Conversation

@vincepri
Copy link
Member

@vincepri vincepri commented Sep 4, 2019

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1369

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@vincepri
Copy link
Member Author

vincepri commented Sep 4, 2019

/test pull-cluster-api-test

@vincepri vincepri changed the title 🏃 Add more items to book's structure WIP: 📖Quickstart / add other sections Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2019
@vincepri
Copy link
Member Author

vincepri commented Sep 4, 2019

/cc @pickledrick

@k8s-ci-robot
Copy link
Contributor

@vincepri: GitHub didn't allow me to request PR reviews from the following users: pickledrick.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pickledrick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri vincepri changed the title WIP: 📖Quickstart / add other sections WIP: 📖 Quickstart / add other sections Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@vincepri vincepri force-pushed the structure-book branch 2 times, most recently from 0f7dc8b to 057e3fb Compare September 5, 2019 00:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2019
@vincepri vincepri force-pushed the structure-book branch 5 times, most recently from 8922847 to 66bc3fb Compare September 5, 2019 14:54
@timothysc
Copy link
Contributor

/assign @timothysc

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2019
@vincepri vincepri force-pushed the structure-book branch 3 times, most recently from 44eb8c3 to 1cf80a3 Compare September 6, 2019 15:45
@vincepri vincepri force-pushed the structure-book branch 3 times, most recently from 73c946a to ef1bf9e Compare September 6, 2019 17:08
@vincepri vincepri force-pushed the structure-book branch 5 times, most recently from 5b6155b to e6214ae Compare September 6, 2019 17:57
@detiber
Copy link
Contributor

detiber commented Sep 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 589e45c into kubernetes-sigs:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/book: Quick Start

5 participants