-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Avoid using deprecated client.Patch method #12737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only need to update the methods in managedfields_test.go file like
Is it recommended to convert structured to unstructured before using Apply? |
internal/controllers/machinedeployment/machinedeployment_controller_test.go
Outdated
Show resolved
Hide resolved
fc4e1e6
to
2550538
Compare
2550538
to
ee49438
Compare
/lgtm |
LGTM label has been added. Git tree hash: b1d11a3bf2cea81671f8a2716fa3788030d64d68
|
/test pull-cluster-api-e2e-main Thank you very much! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unrelated flakes, will be fixed separately /override pull-cluster-api-e2e-main |
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR contains the changes remove usage of deprecated client.Patch method
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # Part of 12695