Update controller-tools / fix CI verify step #1255
Conversation
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @detiber |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
fix-make-verify
branch
from
23c36c4 to
3eacfef
Compare
| set -o pipefail | ||
|
|
||
| command -v doctoc || echo "doctoc is not available on your system, skipping verification" && exit 0 | ||
|
|
There was a problem hiding this comment.
Doesn't this negate the purpose of this script?
There was a problem hiding this comment.
It can still be run locally, although I'm unaware if CI contains doctoc. If it doesn't this should probably move to a Dockerfile, wdyt?
There was a problem hiding this comment.
Running it locally doesn't help the use case that the verify script was intended for, though which is to ensure the TOCs are up to date on merge.
That said, I'm fine if we defer and track an issue to resolve later.
There was a problem hiding this comment.
Sounds good to me, this should have been caught in the other PR I admit
|
/lgtm |
k8s-ci-robot
added
the
lgtm
3 participants
What this PR does / why we need it:
This PR updates controller-tools to latest master release (which has a fix for
controller-gendeepcopy files) and fixes the CI verify stepWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: