Skip to content

⚠️ Change type of *string fields with invalid zero value to string #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

⚠️ Change type of *string fields with invalid zero value to string #12429

merged 2 commits into from
Jul 2, 2025

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 1, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and g-gaston July 1, 2025 12:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Jul 1, 2025
@sbueringer sbueringer mentioned this pull request Jul 1, 2025
Closed
62 tasks
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 1, 2025
@sbueringer sbueringer force-pushed the pr-optionalfields-string branch 4 times, most recently from 7c27fee to 93295a9 Compare July 1, 2025 14:20
@sbueringer sbueringer changed the title [WIP] ⚠️ Change type of *string fields with invalid zero value to string ⚠️ Change type of *string fields with invalid zero value to string Jul 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@sbueringer sbueringer added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/api Issues or PRs related to the APIs labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-area PR is missing an area label do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 1, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member Author

/hold

For Fabrizio's review (+ probably want to merge the bool PR before)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
@sbueringer
Copy link
Member Author

/assign @JoelSpeed @sivchari @fabriziopandini

@sbueringer sbueringer force-pushed the pr-optionalfields-string branch from 93295a9 to 1e89303 Compare July 2, 2025 07:54
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@JoelSpeed
Copy link
Contributor

/lgtm

API changes make sense

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d1154ad271f885ecdabe99fb2bc957b25be9f05

@sivchari
Copy link
Member

sivchari commented Jul 2, 2025

After CI will pass, lgtm

fabriziopandini
fabriziopandini reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 2, 2025
@sbueringer sbueringer force-pushed the pr-optionalfields-string branch from 1e89303 to 8075677 Compare July 2, 2025 15:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 8075677 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fabriziopandini
fabriziopandini reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d75c645a4add674f0da6cec0af068e6a5a3fbd1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit ed4e6b2 into kubernetes-sigs:main Jul 2, 2025
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 2, 2025
@sbueringer sbueringer deleted the pr-optionalfields-string branch July 2, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sivchari sivchari Awaiting requested review from sivchari

Assignees

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

@sivchari sivchari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @JoelSpeed @k8s-ci-robot @sivchari @fabriziopandini