Skip to content

⚠️ Drop unnecessary fields from remediationTemplate references #12368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

⚠️ Drop unnecessary fields from remediationTemplate references #12368

merged 3 commits into from
Jun 18, 2025

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Another cleanup to keep our API surface as small as clean as we can

Part of #6539

/area machinehealthcheck

@k8s-ci-robot k8s-ci-robot added area/machinehealthcheck Issues or PRs related to machinehealthchecks cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari June 17, 2025 13:26
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vincepri June 17, 2025 13:26
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2025
@fabriziopandini fabriziopandini force-pushed the refactor-MHC-reference branch from 09a529e to a887cd0 Compare June 17, 2025 13:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@fabriziopandini fabriziopandini force-pushed the refactor-MHC-reference branch from a887cd0 to 5e8830a Compare June 17, 2025 13:53
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@fabriziopandini
Drop unnecessary fields from remediationTemplate references
53459e2 
# Conflicts:
#	api/core/v1beta1/conversion.go
#	api/core/v1beta1/zz_generated.conversion.go
@fabriziopandini
Address feedback
ac75387
@fabriziopandini fabriziopandini force-pushed the refactor-MHC-reference branch from 5e8830a to ac75387 Compare June 17, 2025 15:17
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

sbueringer
sbueringer reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nits from my side

@sbueringer sbueringer mentioned this pull request Jun 18, 2025
Merged
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 18, 2025
@sbueringer
Copy link
Member

sbueringer commented Jun 18, 2025 •
edited
Loading

Thank you!

/lgtm
/assign @JoelSpeed

I would like to merge this PR in the next few hours so I can rebase #12356. There is a public holidy + some PTO over the next few days, so I want to make sure #12356 can be reviewed in the meantime.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 920f26775381f734d5bec13075de61fa1c1bfb08

@JoelSpeed
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit ce4c050 into kubernetes-sigs:main Jun 18, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 18, 2025
@fabriziopandini fabriziopandini deleted the refactor-MHC-reference branch July 22, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@sivchari sivchari Awaiting requested review from sivchari

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinehealthcheck Issues or PRs related to machinehealthchecks cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @JoelSpeed