🌱 CAPIM: mux: Ignore net.ErrClosed error during listener close & server shutdown #12212
Conversation
Signed-off-by: sivchari <[email protected]>
|
@sivchari: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/area ci |
k8s-ci-robot
added
area/ci
|
/assign @fabriziopandini Let's change the PR title to provide more context where we are fixing something |
|
/retitle 🌱 Ignore net.ErrClosed error when we already closed lister connection. |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d01a01cb3c0954195e13fff4667687031d88ee99
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
changed the title
|
|
||
| if wcl.listener != nil { | ||
| if err := wcl.listener.Close(); err != nil { | ||
| if err := wcl.listener.Close(); !errors.Is(err, net.ErrClosed) { |
There was a problem hiding this comment.
@sivchari @fabriziopandini We are now hitting l.616 if err is nil
There was a problem hiding this comment.
Oops, I'd follow up it.
sbueringer
changed the title
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sbueringer
added
the
area/provider/infrastructure-in-memory
What this PR does / why we need it:
TestMux is flaky since if the wcl.lister has already been closed, Close return net.ErrClosed.
This flaky depends on the timing of Serve.
So I made these ignore the error if the server is already closed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area test
/kind bug