Skip to content

Conversation

cprivitere
Copy link
Member

What this PR does / why we need it:

Adding the kind 0.27 v1.33.0 image to mapper.go so that e2e tests can use v1.33 as a source cluster when testing v1.10.
Bumps the e2e tests for main and v1.10 in clusterctl_upgrade_test.go to use v1.33.0 kubernetes. This resolves some todo comments.

Depends on #12192

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and JoelSpeed May 12, 2025 19:24
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2025
@cprivitere cprivitere changed the title 🌱 Bumps clusterctl_upgrade_test.go main and 1.10 tests to k8s v1.33.0 🌱 Bump clusterctl_upgrade_test.go main and 1.10 tests to k8s v1.33.0 May 12, 2025
@cprivitere cprivitere mentioned this pull request May 12, 2025
43 tasks
@sbueringer
Copy link
Member

Change is fine. Let's check if it works before we released a new v1.10 version with the mapper with v1.33.0 (I think it should work as it probably just falls back to the right image)

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-blocking-main
/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-blocking-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

Change is fine. Let's check if it works before we released a new v1.10 version with the mapper with v1.33.0 (I think it should work as it probably just falls back to the right image)

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer
Copy link
Member

/lgtm
/approve

(Prow will block if it doesn't work yet)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90ca402b7be90c10263eaf2accc07be56ecb59d7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@sbueringer
Copy link
Member

Looks like an unrelated flake

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5526115 into kubernetes-sigs:main May 13, 2025
31 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 13, 2025
@cprivitere cprivitere deleted the update-clusterctl-upgrade-test branch May 14, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants