Skip to content

🐛 Fix MaxLength of worker topology Name fields #12072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

🐛 Fix MaxLength of worker topology Name fields #12072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bdfd6c
Fix MaxLength of worker topology Name fields
dlipovetsky Apr 8, 2025
3438ebf
fixup! Fix MaxLength of worker topology Name fields
dlipovetsky Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1beta1/cluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ type MachineDeploymentTopology struct {
// the values are hashed together.
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=256
// +kubebuilder:validation:MaxLength=63
Name string `json:"name"`

// failureDomain is the failure domain the machines will be created in.
Expand Down Expand Up @@ -797,7 +797,7 @@ type MachinePoolTopology struct {
// the values are hashed together.
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=256
// +kubebuilder:validation:MaxLength=63
Name string `json:"name"`

// failureDomains is the list of failure domains the machine pool will be created in.
Expand Down
4 changes: 2 additions & 2 deletions api/v1beta2/cluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ type MachineDeploymentTopology struct {
// the values are hashed together.
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=256
// +kubebuilder:validation:MaxLength=63
Name string `json:"name"`

// failureDomain is the failure domain the machines will be created in.
Expand Down Expand Up @@ -797,7 +797,7 @@ type MachinePoolTopology struct {
// the values are hashed together.
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=256
// +kubebuilder:validation:MaxLength=63
Name string `json:"name"`

// failureDomains is the list of failure domains the machine pool will be created in.
Expand Down
8 changes: 4 additions & 4 deletions config/crd/bases/cluster.x-k8s.io_clusters.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.