-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[release-1.8] 🌱 Improve Machine remediation logs #11708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.8] 🌱 Improve Machine remediation logs #11708
Conversation
|
@fabriziopandini: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| if nextCheck > 0 { | ||
| logger.V(3).Info("Target is likely to go unhealthy", "timeUntilUnhealthy", nextCheck.Truncate(time.Second).String()) | ||
| logger.V(3).Info("Machine is likely to go unhealthy", "timeUntilUnhealthy", nextCheck.Truncate(time.Second).String()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fyi, this is not fixed on main. Just in case you want to fix it there as well
(overall there are 7 occurences of "Target in this file on main)
|
Thx! /lgtm |
|
LGTM label has been added. Git tree hash: 3565a077b8842850dd0e13e0501883c93babe2cb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manual cherry pick for #11692
/area machinehalthcheck