Change remote.NewClusterClient to return a controller-runtime client.Client

[ncdc]

The current signature

func NewClusterClient(c client.Client, cluster *clusterv1.Cluster) (ClusterClient, error)

should be changed to

func NewClusterClient(c client.Client, cluster *clusterv1.Cluster, scheme runtime.Scheme) (client.Client, error)

It would be nice to omit scheme, but I'm not sure if that's possible.

The reason for making this change is that it reduces our use on typed clients - the ClusterClient interface uses the CoreV1() typed clientset.

Because the drain code uses client-go's type client kubernetes.Interface, we will probably need to create a new RestConfig() method (used by

cluster-api/controllers/machine_controller.go

Line 285 in 9bb9187

kubeClient, err = kubernetes.NewForConfig(remoteClient.RESTConfig())

)

/priority important-longterm
/help
/kind cleanup

[k8s-ci-robot]

@ncdc:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

The current signature

func NewClusterClient(c client.Client, cluster *clusterv1.Cluster) (ClusterClient, error)

should be changed to

func NewClusterClient(c client.Client, cluster *clusterv1.Cluster, scheme runtime.Scheme) (client.Client, error)

It would be nice to omit scheme, but I'm not sure if that's possible.

The reason for making this change is that it reduces our use on typed clients - the ClusterClient interface uses the CoreV1() typed clientset.

Because the drain code uses client-go's type client kubernetes.Interface, we will probably need to create a new RestConfig() method (used by

cluster-api/controllers/machine_controller.go

Line 285 in 9bb9187

kubeClient, err = kubernetes.NewForConfig(remoteClient.RESTConfig())

)

/priority important-longterm
/help
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/milestone v0.3.0

Whoever works on this, please document this breaking change in the tracking document https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/providers/v1alpha2-to-v1alpha3.md :)

[noamran]

/assign

[ncdc]

cc @akutz for feedback - how do you feel about a change like this?