Machine should not be considered healthy until it has a node

Author: JoelSpeed

controllers/machinehealthcheck_targets.go

@@ -301,7 +301,7 @@ func (r *MachineHealthCheckReconciler) healthCheckTargets(targets []healthCheckT
 			continue
 		}
 
-		if t.Machine.DeletionTimestamp.IsZero() {
+		if t.Machine.DeletionTimestamp.IsZero() && t.Node != nil {
 			conditions.MarkTrue(t.Machine, clusterv1.MachineHealthCheckSuccededCondition)
 			healthy = append(healthy, t)
 		}

controllers/machinehealthcheck_targets_test.go

@@ -373,9 +373,9 @@ func TestHealthCheckTargets(t *testing.T) {
 			desc:                        "when the node has not started for a long time but the startup timeout is disabled",
 			targets:                     []healthCheckTarget{nodeNotYetStartedTarget400s},
 			timeoutForMachineToHaveNode: &disabledTimeoutForMachineToHaveNode,
-			expectedHealthy:             []healthCheckTarget{},
+			expectedHealthy:             []healthCheckTarget{}, // The node is not healthy as it does not have a machine
 			expectedNeedsRemediation:    []healthCheckTarget{},
-			expectedNextCheckTimes:      []time.Duration{1 * time.Minute},
+			expectedNextCheckTimes:      []time.Duration{}, // We don't have a timeout so no way to know when to re-check
 		},
 	}