Make timeout comparison more obvious

Author: JoelSpeed

controllers/machinehealthcheck_targets.go

@@ -44,6 +44,11 @@ const (
 	EventDetectedUnhealthy string = "DetectedUnhealthy"
 )
 
+var (
+	// We allow users to disable the nodeStartupTimeout by setting the duration to 0.
+	disabledNodeStartupTimeout = metav1.Duration{Duration: 0}
+)
+
 // healthCheckTarget contains the information required to perform a health check
 // on the node to determine if any remediation is required.
 type healthCheckTarget struct {
@@ -120,7 +125,7 @@ func (t *healthCheckTarget) needsRemediation(logger logr.Logger, timeoutForMachi
 
 	// the node has not been set yet
 	if t.Node == nil {
-		if isZero(timeoutForMachineToHaveNode) {
+		if timeoutForMachineToHaveNode.Seconds() == disabledNodeStartupTimeout.Seconds() {
 			// Startup timeout is disabled so no need to go any further.
 			// No node yet to check conditions, can return early here.
 			return false, 0
@@ -342,7 +347,3 @@ func shouldSkipRemediation(m *clusterv1.Machine) (bool, string) {
 
 	return false, ""
 }
-
-func isZero(d time.Duration) bool {
-	return d == time.Duration(0)
-}