Skip to content

Conversation

@andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Oct 4, 2019

Signed-off-by: Andrew Sy Kim [email protected]

What this PR does / why we need it:
Adds toleration for well-known taints like node-role.kubernetes.io/master to released CAPV manager manifest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-sigs/cluster-api#1486

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Adds toleration for well-known taints like node-role.kubernetes.io/master to released CAPV manager manifest.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2019
Copy link
Contributor

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this as a patch in the same dir.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
@andrewsykim
Copy link
Member Author

Please add this as a patch in the same dir.

Is this necessary if all variations of this will have this toleration?

@akutz
Copy link
Contributor

akutz commented Oct 4, 2019

Is this necessary if all variations of this will have this toleration?

I only want to make sure we can replace manager.yaml with whatever upstream template gets updated over time. If the upstream template includes the toleration, then this is fine as is.

@andrewsykim
Copy link
Member Author

Yeah this should be consistent with upstream - kubernetes-sigs/cluster-api#1487

@akutz
Copy link
Contributor

akutz commented Oct 4, 2019

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit e362c70 into kubernetes-sigs:master Oct 4, 2019
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this pull request Feb 26, 2020
silvery1622 pushed a commit to silvery1622/cluster-api-provider-vsphere that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CAPI quickstart doesn't work if existing cluster has taints

3 participants