-
Notifications
You must be signed in to change notification settings - Fork 305
add well-known tolerations to released CAPV manager manifest #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add well-known tolerations to released CAPV manager manifest #605
Conversation
Signed-off-by: Andrew Sy Kim <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
akutz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this as a patch in the same dir.
/hold
Is this necessary if all variations of this will have this toleration? |
I only want to make sure we can replace |
|
Yeah this should be consistent with upstream - kubernetes-sigs/cluster-api#1487 |
|
/hold cancel |
Signed-off-by: Andrew Sy Kim [email protected]
What this PR does / why we need it:
Adds toleration for well-known taints like node-role.kubernetes.io/master to released CAPV manager manifest.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes kubernetes-sigs/cluster-api#1486
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: