Skip to content

Conversation

@jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Feb 6, 2020

per https://master.cluster-api.sigs.k8s.io/clusterctl/developers.html
Each provider must have a clusterctl-settings.json
file describing how to build the provider assets.

currently using v0.2.0 and follow on we might need moidfy the value

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


per https://master.cluster-api.sigs.k8s.io/clusterctl/developers.html
Each provider must have a clusterctl-settings.json
file describing how to build the provider assets.

currently using v0.2.0 and follow on we might need moidfy the value
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@jichenjc
Copy link
Contributor Author

jichenjc commented Feb 6, 2020

/test pull-cluster-api-provider-openstack-test

@prankul88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 25363e5 into kubernetes-sigs:master Feb 12, 2020
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
per https://master.cluster-api.sigs.k8s.io/clusterctl/developers.html
Each provider must have a clusterctl-settings.json
file describing how to build the provider assets.

currently using v0.2.0 and follow on we might need moidfy the value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants