Skip to content

Conversation

@hidekazuna
Copy link
Contributor

What this PR does / why we need it:

This PR updates cluster-api from v0.1.4 to v0.1.9.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #439

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2019
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@jichenjc
Copy link
Contributor

@hidekazuna we need update
cmd/clusterctl/examples/openstack/provider-component/cluster-api/manager_image_patch.yaml
to v0.1.9 ... and check the location here
kubernetes-sigs/cluster-api#1258

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
spec:
containers:
- image: gcr.io/k8s-cluster-api/cluster-api-controller:v0.1.4
- image: us.gcr.io/k8s-artifacts-prod/cluster-api/cluster-api-controller:v0.1.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intended to swtich to us.gcr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbueringer I do not know the exact reason, see kubernetes-sigs/cluster-api#1258

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, good enough :)

@jichenjc
Copy link
Contributor

root@jj-master:~/go/src/sigs.k8s.io/cluster-api-provider-openstack/cmd/clusterctl# kubectl describe pod controller-manager-0 -n system --kubeconfig kubeconfig
Name: controller-manager-0
Namespace: system
........
Image: us.gcr.io/k8s-artifacts-prod/cluster-api/cluster-api-controller:v0.1.9

spaces
NAME STATUS ROLES AGE VERSION
openstack-master-9r8mq Ready master 28m v1.15.0
openstack-node-47qhn Ready node 24m v1.15.0

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 62f6aff into kubernetes-sigs:master Aug 16, 2019
@hidekazuna hidekazuna deleted the CAPI_019 branch August 19, 2019 02:09
prankul88 pushed a commit to prankul88/cluster-api-provider-openstack that referenced this pull request Sep 5, 2019
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update to cluster-api v0.1.9

4 participants