Skip to content

Conversation

@jichenjc
Copy link
Contributor

What this PR does / why we need it:

The PR #421 has some missing code change for ubuntu and centos,
I created ubuntu correctly but centos has some issue (#391), so modify the code according to
ubuntu changes only

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2019
@jichenjc
Copy link
Contributor Author

@sbueringer PTAL, thanks

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@sbueringer
Copy link
Member

sbueringer commented Aug 15, 2019

But if this PR here works for you it means we don't need the cacert for APIServer, right? :)

Which makes sense to me. Because I don't think APIServer calls OpenStack

@k8s-ci-robot k8s-ci-robot merged commit 3753055 into kubernetes-sigs:master Aug 15, 2019
@jichenjc
Copy link
Contributor Author

@sbueringer
Copy link
Member

@sbueringer
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/openstack/services/userdata/kubeadm.go#L71 already has it

Yup. But only for the controller-manager. The apiserver has the same cloudprovider openstack flags but no cacert

@jichenjc
Copy link
Contributor Author

ok, maybe I missed something, anyway, let's be it and if we find some issue later, we can do modifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants