-
Notifications
You must be signed in to change notification settings - Fork 284
follow up PR 421 to make ubuntu and centos work #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow up PR 421 to make ubuntu and centos work #438
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbueringer PTAL, thanks |
...sterctl/examples/openstack/provider-component/user-data/ubuntu/templates/worker-user-data.sh
Outdated
Show resolved
Hide resolved
531d439 to
501a60a
Compare
|
/lgtm |
|
But if this PR here works for you it means we don't need the cacert for APIServer, right? :) Which makes sense to me. Because I don't think APIServer calls OpenStack |
Yup. But only for the controller-manager. The apiserver has the same cloudprovider openstack flags but no cacert |
|
ok, maybe I missed something, anyway, let's be it and if we find some issue later, we can do modifications |
What this PR does / why we need it:
The PR #421 has some missing code change for ubuntu and centos,
I created ubuntu correctly but centos has some issue (#391), so modify the code according to
ubuntu changes only
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: