Fix delete pool lead to panic #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
hidekazuna
reviewed
Aug 10, 2019
| lbID := clusterProviderStatus.Network.APIServerLoadBalancer.ID | ||
|
|
||
| for _, port := range []int{22, 6443} { | ||
| for _, port := range []int{6443} { |
Contributor
There was a problem hiding this comment.
When we create the listener and pool, we are doing like:
portList := []int{clusterProviderSpec.APIServerLoadBalancerPort}
portList = append(portList, clusterProviderSpec.APIServerLoadBalancerAdditionalPorts...)
for _, port := range portList {
lbPortObjectsName := fmt.Sprintf("%s-%d", loadBalancerName, port)
Member
There was a problem hiding this comment.
Oh sorry, I thought I already fixed that somewhere.
So the solution is to remove the same list of ports that have been added before
k8s-ci-robot
added
needs-rebase
1) seems we don't need port 22, have no idea why use here 2) when pool not exist, should check and ignore following actions
k8s-ci-robot
removed
the
needs-rebase
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
1) seems we don't need port 22, have no idea why use here 2) when pool not exist, should check and ignore following actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #429
Special notes for your reviewer:
Release note: