Skip to content

Conversation

@jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Aug 5, 2019

cloud provider and others might create this kind of resource
as well, we might consider to make it clusterapi specific

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


cloud provider and others might create this kind of resource
as well, we might consider to make it clusterapi specific
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2019
@sbueringer
Copy link
Member

@jichenjc Are they really creating additional networks?

@jichenjc
Copy link
Contributor Author

jichenjc commented Aug 6, 2019

they use k8s a lot, my assumption is to either make it clear created by clusterapi, or we make it configurable for resources created by us to avoid consume people ...anyway, just my own thought

@sbueringer
Copy link
Member

It's fine for me. Just wanted to ask :). In the current state of the ClusterAPI provider I don't really care about changes like this. After a release this would be a breaking change :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit d43c67f into kubernetes-sigs:master Aug 6, 2019
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
cloud provider and others might create this kind of resource
as well, we might consider to make it clusterapi specific
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants