Fix failed to create cluster

[jichenjc]

this is different to container (statefulset), it's clusterctl command
that didn't register openstack provider

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #395

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

@sbueringer can you help to take a look at this ? I tried the master and encounter issue or I might missed something ?

[sbueringer]

@jichenjc Yup I'll check

[sbueringer]

@jichenjc
What error do you get? Are you using kubeadm/Kubernetes 1.14 or 1.15? Which APIServer Port is used according to your UserData? I also needed you're fix, I forgot to check clusterctl, sorry :/. But after that I get at least the Master Node up until the pivoting phase. Does it fail before that on your environment?

I can also try the rest of the clusterctl bootstrap but I have to apply a few more adjustments to get the current master working on my environment

[jichenjc]

@sbueringer please refer to bug #395, I used master code and I got error right after execution
I thought you may updated the image ,but can you confirm you updated clusterctl execute files as well? Thanks

[jichenjc]

The error info was listed in #395, I didn't have time to try a full test but at least my PR here can fix that issue...

[sbueringer]

@sbueringer please refer to bug #395, I used master code and I got error right after execution
I thought you may updated the image ,but can you confirm you updated clusterctl execute files as well? Thanks

Updated clusterctl in the sense of made changes so that the compiled code changed? Yes.

Maybe I understood you wrong. I definitely introduced the bug #395 and this PR is absolutely necessary to fix this. I thought you have a bug even with this fix?

[sbueringer]

/lgtm

[sbueringer]

Thx for fixing it :)

[jichenjc]

thanks, I will do further test on master then and along with the new cert you introduced ,I think that's a great PR and I will give it a try early next week :) thank you

[sbueringer]

Okay perfect. Thanks. I'll also test the other PR with clusterctl & CoreOS. Didn't test it that much with clusterctl until now and only with the controllers, because I still need a few hacks to get it working with our restrictions (no Internet access & no Access to Floating IPs in the cluster) so it's kind of painful :). But It's getting better with each PR :D.