Skip to content

Conversation

@apricote
Copy link
Member

What this PR does / why we need it:

Renames the upcoming API Version from v1beta1 to v1alpha5 to avoid making commitments about the API stability. We made quite a few changes to the API and want to validate that it feels right before committing on it.

See issue #1196 for an deeper explanation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1196

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

PR on hold until we have a consensus from all maintainers for this rename.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2022
@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 311741f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/625813231636f50009f6f0e4
😎 Deploy Preview https://deploy-preview-1198--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2022
@seanschneeweiss
Copy link
Contributor

Looks like the admissionregistration is not happy with v1alpha5.

action failed after 10 attempts: failed to create provider object admissionregistration.k8s.io/v1, Kind=MutatingWebhookConfiguration, /capo-mutating-webhook-configuration: MutatingWebhookConfiguration.admissionregistration.k8s.io "capo-mutating-webhook-configuration" is invalid: [webhooks[0].admissionReviewVersions: Invalid value: []string{"v1alpha5"}: must include at least one of v1, v1beta1, 
  occurred 

@apricote
Copy link
Member Author

Yes, it looks like I overeagerly replaced a v1beta1 that referred to something other than the CAPO api group. I will push a fix tomorrow

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2022
@apricote
Copy link
Member Author

/retest

Looks like a devstack failure to me

@apricote
Copy link
Member Author

@apricote
Copy link
Member Author

/milestone v0.6

@tobiasgiese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2022
@apricote
Copy link
Member Author

/hold cancel

Just waiting for an approval now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022
@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit af6f623 into kubernetes-sigs:main Apr 19, 2022
@apricote apricote deleted the rename-v1beta1-v1alpha5 branch April 19, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename API Version v1beta1 to v1alpha5

5 participants