-
Notifications
You must be signed in to change notification settings - Fork 284
⚠️ rename v1beta1 to v1alpha5 #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ rename v1beta1 to v1alpha5 #1198
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Looks like the admissionregistration is not happy with v1alpha5. |
|
Yes, it looks like I overeagerly replaced a |
|
/retest Looks like a devstack failure to me |
|
/retest the e2e test succeeded recently in another pr: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1204/pull-cluster-api-provider-openstack-e2e-test/1514418132024823808 |
|
/milestone v0.6 |
|
/lgtm |
|
/hold cancel Just waiting for an approval now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Renames the upcoming API Version from
v1beta1tov1alpha5to avoid making commitments about the API stability. We made quite a few changes to the API and want to validate that it feels right before committing on it.See issue #1196 for an deeper explanation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1196
Special notes for your reviewer:
PR on hold until we have a consensus from all maintainers for this rename.
/hold